don't test self-deletion in stateful tests #3243
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
needs release notes
dcherian
reviewed
Jul 14, 2025
src/zarr/testing/stateful.py
Outdated
| group_path = data.draw( | ||
| st.sampled_from(sorted(self.all_groups)), label="Group deletion target" | ||
| ) | ||
| members = tuple(filter(lambda v: "/" in v, sorted(self.all_groups))) |
There was a problem hiding this comment.
- this will filter out
foo/bartoo no?
Suggested change
| members = tuple(filter(lambda v: "/" in v, sorted(self.all_groups))) | |
| members = tuple(filter(lambda v: v == "/", sorted(self.all_groups))) |
- Should this op be an error?
There was a problem hiding this comment.
this will filter out foo/bar too no?
It will reject any member name that doesn't contain "/", so it will keep foo/bar
There was a problem hiding this comment.
I'm confused about how this is working. Can you add a comment please?
There was a problem hiding this comment.
let me know if this explanation needs more context, or if there's just a better way to get the same result -- I'm assuming it's a given that the name of the root group does not contain a "/" character.
|
closes #3244 |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3243 +/- ##
==========================================
+ Coverage 92.25% 94.62% +2.37%
==========================================
Files 78 78
Lines 8689 8690 +1
==========================================
+ Hits 8016 8223 +207
+ Misses 673 467 -206
🚀 New features to boost your workflow:
|
dcherian
approved these changes
Jul 14, 2025
This was referenced Jul 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR prevents the stateful group tests from deleting the root group
TODO:
docs/user-guide/*.rstchanges/